fixes parameter naming

This commit is contained in:
Quentin De Coninck 2020-06-25 17:01:58 +02:00
parent 1af62ad8d1
commit 93b9b31ab5
18 changed files with 54 additions and 54 deletions

View File

@ -10,25 +10,25 @@ class ExperienceParameter(Parameter):
SCHED = "sched" SCHED = "sched"
CC = "congctrl" CC = "congctrl"
AUTOCORK = "autocork" AUTOCORK = "autocork"
EARLYRETRANS = "earlyRetrans" EARLY_RETRANS = "earlyRetrans"
KERNELPM = "kpm" KERNELPM = "kpm"
KERNELPMC = "kpmc" #kernel path manager client / server KERNELPMC = "kpmc" #kernel path manager client / server
KERNELPMS = "kpms" KERNELPMS = "kpms"
USERPMC = "upmc" USERPMC = "upmc"
USERPMS = "upms" #userspace path manager client / server USERPMS = "upms" #userspace path manager client / server
USERPMCARGS = "upmc_args" USERPMC_ARGS = "upmc_args"
USERPMSARGS = "upms_args" USERPMS_ARGS = "upms_args"
CLIENTPCAP = "clientPcap" CLIENT_PCAP = "clientPcap"
SERVERPCAP = "serverPcap" SERVER_PCAP = "serverPcap"
SNAPLENPCAP = "snaplenPcap" SNAPLEN_PCAP = "snaplenPcap"
XPTYPE = "xpType" XP_TYPE = "xpType"
PINGCOUNT = "pingCount" PING_COUNT = "pingCount"
PRIOPATH0 = "prioPath0" PRIO_PATH0 = "prioPath0"
PRIOPATH1 = "prioPath1" PRIO_PATH1 = "prioPath1"
BACKUPPATH0 = "backupPath0" BACKUP_PATH0 = "backupPath0"
BACKUPPATH1 = "backupPath1" BACKUP_PATH1 = "backupPath1"
EXPIRATION = "expiration" EXPIRATION = "expiration"
BUFFERAUTOTUNING = "bufferAutotuning" BUFFER_AUTOTUNING = "bufferAutotuning"
METRIC = "metric" METRIC = "metric"
@ -40,9 +40,9 @@ class ExperienceParameter(Parameter):
SCHED: "net.mptcp.mptcp_scheduler", SCHED: "net.mptcp.mptcp_scheduler",
CC: "net.ipv4.tcp_congestion_control", CC: "net.ipv4.tcp_congestion_control",
AUTOCORK: "net.ipv4.tcp_autocorking", AUTOCORK: "net.ipv4.tcp_autocorking",
EARLYRETRANS: "net.ipv4.tcp_early_retrans", EARLY_RETRANS: "net.ipv4.tcp_early_retrans",
EXPIRATION: "net.mptcp.mptcp_sched_expiration", EXPIRATION: "net.mptcp.mptcp_sched_expiration",
BUFFERAUTOTUNING: "net.ipv4.tcp_moderate_rcvbuf", BUFFER_AUTOTUNING: "net.ipv4.tcp_moderate_rcvbuf",
} }
# sysctl keys specific to client and server, independently # sysctl keys specific to client and server, independently
@ -62,24 +62,24 @@ class ExperienceParameter(Parameter):
KERNELPMS: "fullmesh", KERNELPMS: "fullmesh",
USERPMC: "fullmesh", USERPMC: "fullmesh",
USERPMS: "fullmesh", USERPMS: "fullmesh",
USERPMCARGS: "", USERPMC_ARGS: "",
USERPMSARGS: "", USERPMS_ARGS: "",
CC: "olia", CC: "olia",
SCHED: "default", SCHED: "default",
AUTOCORK: "1", AUTOCORK: "1",
EARLYRETRANS: "3", EARLY_RETRANS: "3",
EXPIRATION: "300", EXPIRATION: "300",
BUFFERAUTOTUNING: "1", BUFFER_AUTOTUNING: "1",
METRIC: "-1", METRIC: "-1",
CLIENTPCAP: "no", CLIENT_PCAP: "no",
SERVERPCAP: "no", SERVER_PCAP: "no",
SNAPLENPCAP: "65535", # Default snapping value of tcpdump SNAPLEN_PCAP: "65535", # Default snapping value of tcpdump
XPTYPE: "none", XP_TYPE: "none",
PINGCOUNT: "5", PING_COUNT: "5",
PRIOPATH0: "0", PRIO_PATH0: "0",
PRIOPATH1: "0", PRIO_PATH1: "0",
BACKUPPATH0: "0", BACKUP_PATH0: "0",
BACKUPPATH1: "0", BACKUP_PATH1: "0",
} }
def __init__(self, parameter_filename): def __init__(self, parameter_filename):
@ -175,8 +175,8 @@ class Experience(object):
""" """
# Only meaningful if mpTopo is instance of MultiInterfaceTopo # Only meaningful if mpTopo is instance of MultiInterfaceTopo
if isinstance(self.topo, MultiInterfaceTopo): if isinstance(self.topo, MultiInterfaceTopo):
prioPath0 = self.experience_parameter.get(ExperienceParameter.PRIOPATH0) prioPath0 = self.experience_parameter.get(ExperienceParameter.PRIO_PATH0)
prioPath1 = self.experience_parameter.get(ExperienceParameter.PRIOPATH1) prioPath1 = self.experience_parameter.get(ExperienceParameter.PRIO_PATH1)
if not prioPath0 == prioPath1: if not prioPath0 == prioPath1:
self.topo.command_to(self.topo_config.client, "/home/mininet/iproute/ip/ip link set dev " + self.topo.command_to(self.topo_config.client, "/home/mininet/iproute/ip/ip link set dev " +
self.topo_config.getClientInterface(0) + " priority " + str(prioPath0)) self.topo_config.getClientInterface(0) + " priority " + str(prioPath0))
@ -189,11 +189,11 @@ class Experience(object):
self.topo_config.getRouterInterfaceSwitch(1) + " priority " + self.topo_config.getRouterInterfaceSwitch(1) + " priority " +
str(prioPath1)) str(prioPath1))
backupPath0 = self.experience_parameter.get(ExperienceParameter.BACKUPPATH0) backupPath0 = self.experience_parameter.get(ExperienceParameter.BACKUP_PATH0)
if int(backupPath0) > 0: if int(backupPath0) > 0:
self.topo.command_to(self.topo_config.client, self.topo_config.interfaceBUPCommand(self.topo_config.getClientInterface(0))) self.topo.command_to(self.topo_config.client, self.topo_config.interfaceBUPCommand(self.topo_config.getClientInterface(0)))
self.topo.command_to(self.topo_config.router, self.topo_config.interfaceBUPCommand(self.topo_config.getRouterInterfaceSwitch(0))) self.topo.command_to(self.topo_config.router, self.topo_config.interfaceBUPCommand(self.topo_config.getRouterInterfaceSwitch(0)))
backupPath1 = self.experience_parameter.get(ExperienceParameter.BACKUPPATH1) backupPath1 = self.experience_parameter.get(ExperienceParameter.BACKUP_PATH1)
if int(backupPath1) > 0: if int(backupPath1) > 0:
self.topo.command_to(self.topo_config.client, self.topo_config.interfaceBUPCommand(self.topo_config.getClientInterface(1))) self.topo.command_to(self.topo_config.client, self.topo_config.interfaceBUPCommand(self.topo_config.getClientInterface(1)))
self.topo.command_to(self.topo_config.router, self.topo_config.interfaceBUPCommand(self.topo_config.getRouterInterfaceSwitch(1))) self.topo.command_to(self.topo_config.router, self.topo_config.interfaceBUPCommand(self.topo_config.getRouterInterfaceSwitch(1)))
@ -233,14 +233,14 @@ class Experience(object):
print("Client : Error, I can't change the userspace pm if the kernel pm is not netlink !") print("Client : Error, I can't change the userspace pm if the kernel pm is not netlink !")
else: else:
upmc = self.experience_parameter.get(ExperienceParameter.USERPMC) upmc = self.experience_parameter.get(ExperienceParameter.USERPMC)
upmca = self.experience_parameter.get(ExperienceParameter.USERPMCARGS) upmca = self.experience_parameter.get(ExperienceParameter.USERPMC_ARGS)
self.topo.command_to(self.topo_config.client, upmc + \ self.topo.command_to(self.topo_config.client, upmc + \
" " + upmca + " &>upmc.log &") " " + upmca + " &>upmc.log &")
if self.experience_parameter.get(ExperienceParameter.KERNELPMS) != "netlink": if self.experience_parameter.get(ExperienceParameter.KERNELPMS) != "netlink":
print("Server : Error, I can't change the userspace pm if the kernel pm is not netlink !") print("Server : Error, I can't change the userspace pm if the kernel pm is not netlink !")
else: else:
upms = self.experience_parameter.get(ExperienceParameter.USERPMS) upms = self.experience_parameter.get(ExperienceParameter.USERPMS)
upmsa = self.experience_parameter.get(ExperienceParameter.USERPMSARGS) upmsa = self.experience_parameter.get(ExperienceParameter.USERPMS_ARGS)
self.topo.command_to(self.topo_config.server, upms + \ self.topo.command_to(self.topo_config.server, upms + \
" " + upmsa + " &>upms.log &") " " + upmsa + " &>upms.log &")
@ -392,9 +392,9 @@ class Experience(object):
def runTcpDump(self): def runTcpDump(self):
#todo : replace filename by cst #todo : replace filename by cst
cpcap = self.experience_parameter.get(ExperienceParameter.CLIENTPCAP) cpcap = self.experience_parameter.get(ExperienceParameter.CLIENT_PCAP)
spcap = self.experience_parameter.get(ExperienceParameter.SERVERPCAP) spcap = self.experience_parameter.get(ExperienceParameter.SERVER_PCAP)
snaplenpcap = self.experience_parameter.get(ExperienceParameter.SNAPLENPCAP) snaplenpcap = self.experience_parameter.get(ExperienceParameter.SNAPLEN_PCAP)
if cpcap == "yes" : if cpcap == "yes" :
self.topo.command_to(self.topo_config.client, self.topo.command_to(self.topo_config.client,
"tcpdump -i any -s " + snaplenpcap + " -w client.pcap &") "tcpdump -i any -s " + snaplenpcap + " -w client.pcap &")

View File

@ -29,7 +29,7 @@ class AB(RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, self.topo.command_to(self.topo_config.client,
"rm " + AB.PING_OUTPUT) "rm " + AB.PING_OUTPUT)
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -44,7 +44,7 @@ class DITG(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Experience.PING_OUTPUT) Experience.PING_OUTPUT)
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -29,7 +29,7 @@ class Epload(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Epload.PING_OUTPUT ) Epload.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -16,7 +16,7 @@ class HTTP(RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
HTTP.PING_OUTPUT ) HTTP.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -16,7 +16,7 @@ class HTTPS(RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
HTTPS.PING_OUTPUT ) HTTPS.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -29,7 +29,7 @@ class IPerf(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
IPerf.PING_OUTPUT) IPerf.PING_OUTPUT)
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -34,7 +34,7 @@ class Msg(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Msg.PING_OUTPUT ) Msg.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -50,7 +50,7 @@ class NCPV(NC):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
NCPV.PING_OUTPUT ) NCPV.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -34,7 +34,7 @@ class Netperf(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Netperf.PING_OUTPUT) Netperf.PING_OUTPUT)
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -17,7 +17,7 @@ class Ping(Experience):
def run(self): def run(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Ping.PING_OUTPUT ) Ping.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -33,7 +33,7 @@ class QUIC(RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
QUIC.PING_OUTPUT ) QUIC.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -32,7 +32,7 @@ class QUICSiri(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
QUICSiri.PING_OUTPUT ) QUICSiri.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -16,7 +16,7 @@ class SendFile(RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
SendFile.PING_OUTPUT ) SendFile.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -47,7 +47,7 @@ class Siri(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
Siri.PING_OUTPUT ) Siri.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -21,7 +21,7 @@ class SiriHTTP(Siri, RandomFileExperience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
SiriHTTP.PING_OUTPUT ) SiriHTTP.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -29,7 +29,7 @@ class VLC(Experience):
def ping(self): def ping(self):
self.topo.command_to(self.topo_config.client, "rm " + \ self.topo.command_to(self.topo_config.client, "rm " + \
VLC.PING_OUTPUT ) VLC.PING_OUTPUT )
count = self.experience_parameter.get(ExperienceParameter.PINGCOUNT) count = self.experience_parameter.get(ExperienceParameter.PING_COUNT)
for i in range(0, self.topo_config.getClientInterfaceCount()): for i in range(0, self.topo_config.getClientInterfaceCount()):
cmd = self.pingCommand(self.topo_config.getClientIP(i), cmd = self.pingCommand(self.topo_config.getClientIP(i),
self.topo_config.getServerIP(), n = count) self.topo_config.getServerIP(), n = count)

View File

@ -73,7 +73,7 @@ class Runner(object):
Match the name of the experiement and launch it Match the name of the experiement and launch it
""" """
# Well, we need to load twice the experience parameters, is it really annoying? # Well, we need to load twice the experience parameters, is it really annoying?
xp = ExperienceParameter(experience_parameter_file).get(ExperienceParameter.XPTYPE) xp = ExperienceParameter(experience_parameter_file).get(ExperienceParameter.XP_TYPE)
if xp in EXPERIENCES: if xp in EXPERIENCES:
exp = EXPERIENCES[xp](experience_parameter_file, self.topo, self.topo_config) exp = EXPERIENCES[xp](experience_parameter_file, self.topo, self.topo_config)
exp.classic_run() exp.classic_run()