From 3fa6fcb19f3f49a729a032778203f8b6b26b719f Mon Sep 17 00:00:00 2001 From: Raphael Bauduin Date: Mon, 3 Aug 2015 11:10:28 -0700 Subject: [PATCH] added comments --- src/bup_tests/kernelspace/validation.yml | 1 + src/bup_tests/userspace/validation.yml | 1 + src/mpValidations.py | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/bup_tests/kernelspace/validation.yml b/src/bup_tests/kernelspace/validation.yml index 52a784f..0f98ede 100644 --- a/src/bup_tests/kernelspace/validation.yml +++ b/src/bup_tests/kernelspace/validation.yml @@ -1,5 +1,6 @@ checkers: tshark: + # applies provided filter to tcpdump trace and returns number of packets matching - test: "filter" filter: "tcp.options.mptcp.subtype==5" validations: diff --git a/src/bup_tests/userspace/validation.yml b/src/bup_tests/userspace/validation.yml index 52a784f..0f98ede 100644 --- a/src/bup_tests/userspace/validation.yml +++ b/src/bup_tests/userspace/validation.yml @@ -1,5 +1,6 @@ checkers: tshark: + # applies provided filter to tcpdump trace and returns number of packets matching - test: "filter" filter: "tcp.options.mptcp.subtype==5" validations: diff --git a/src/mpValidations.py b/src/mpValidations.py index d204738..56170a4 100644 --- a/src/mpValidations.py +++ b/src/mpValidations.py @@ -127,10 +127,12 @@ class Tester: raise Exception("Method not implemented") +# applies provided filter to Checker's trace, and returns number of lines in output(ie number of packets) class FilterTest(Tester): def get_tested_value(self, yml): if "filter" in self.yml: ret = check_output(["tshark", "-r", self.trace, "-Y", self.yml["filter"]]) + # -1 : substract line of sudo error message printed by tshark return len(ret.split("\n")) - 1 else: raise Exception("Test requires a filter.") @@ -171,6 +173,7 @@ class TcptraceChecker(Checker): self.trace = TcptraceData(destDir+"/client.pcap") self.test_id = test_id +# Runs tests based on the tcpdump trace itself class TsharkChecker(Checker): def __init__(self, yml, test_id, destDir): self.yml = yml["tshark"]